-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.1 / 8.2 Compatibility #7225
Merged
Merged
Changes from 34 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
d11fc69
Run tests against PHP 8.1
swissspidy 7902c3a
Run tests against PHP 8.2
swissspidy 91c050b
Change php file to trigger CI
swissspidy 2443a05
Update PHPUnit depending on matrix
swissspidy 3f37f08
Fix setup/teardown method names in `BlockUniqidTransformerTest`
swissspidy d2c4c95
Add `ReturnTypeWillChange` attribute in `ElementList`
swissspidy e09f922
Remove conflicting Requests library
swissspidy 924be54
Remove float key test case in `EventTest`
swissspidy 3a98e8f
ignore platform reqs
swissspidy 3c0badc
Add `file_exists` check
swissspidy 0ee41fd
Don’t convert to exceptions for now
swissspidy ab075f9
Install PHPUnit 7.x on PHP 7.1
swissspidy db8f0f7
Fix string interpolation in `CachedRemoteGetRequestTest`
swissspidy cf6c769
Avoid passing `null` to `parse_str`
swissspidy 01ab3e9
Add `ReturnTypeWillChange` attribute in `AMP_Validation_Callback_Wrap…
swissspidy e21f5a4
Do not install `pcov/clobber` for PHPUnit 8
swissspidy 84c83ce
Avoid passing `null` to `parse_str`, take 2
swissspidy 0e0d64c
Add missing attribute
swissspidy e42e2b3
Fix another string interpolation issue
swissspidy 2517d89
Update amp-toolbox-php to 0.11.3-alpha
westonruter 35e0ea4
Merge remote-tracking branch 'origin/develop' into try-php81-php82
westonruter 97440f4
Remove temp change
swissspidy 91460a4
Add return type instead of attribute
swissspidy c5f32cd
Use xdebug instead of pcov
swissspidy 5773928
Update `testVersion` in PHPCS config since the plugin requires 7.0+
swissspidy bd2ee42
Address unrelated PHPCS warnings
swissspidy 2ed5103
Make actual use of `$_tests_dir` in test bootstrap
swissspidy 0093af3
Merge branch 'develop' into try-php81-php82
swissspidy 5afdbb3
Merge branch 'develop' into try-php81-php82
swissspidy 7ce100c
Try running coverage on PHP 8.0
swissspidy c0077b1
Fix `test_handle_single_url_page_bulk_and_inline_actions` test
swissspidy 29849b9
Fix `test_prepare_response_throwing_error` on trunk
swissspidy d00f532
Fix automatic conversion of false to array
swissspidy b29258d
Fix `test_prepare_response_throwing_exception`
swissspidy dd4524c
Merge branch 'develop' into try-php81-php82
swissspidy b81b485
Apply suggestions from code review
swissspidy 2473fe6
Merge branch 'develop' into try-php81-php82
westonruter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we continue using
pcov
for coverage in the CI? I've looked at the problem that it uses xdebug in any case, but I can debug it in another PR. Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer to Weston, but if it works and is faster, sure.
But since this never really worked in the first place, definitely warrants its own issue/PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PCOV is faster but lacks path coverage. A difference in reporting can be seen here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PCOV was introduced in #5201
I just pinged you both the thread where this was discussed.