-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation error source attribution for script translations and wp_editor()
#6670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
improve/error-attribution
branch
3 times, most recently
from
November 1, 2021 23:03
f751842
to
17d6f3d
Compare
Note any E2E test failures do not seem related to changes on this PR. |
Plugin builds for 9434454 are ready 🛎️!
|
Rebasing against develop since no one else has pushed commits onto this branch. |
westonruter
force-pushed
the
improve/error-attribution
branch
from
November 3, 2021 04:39
17d6f3d
to
89e2aa6
Compare
dhaval-parekh
approved these changes
Nov 10, 2021
Changes in PR looks good to me 👍 |
…eued by themes/plugins
westonruter
force-pushed
the
improve/error-attribution
branch
from
November 10, 2021 19:18
89e2aa6
to
9434454
Compare
westonruter
added
the
Changelogged
Whether the issue/PR has been added to release notes.
label
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given a site in Transitional mode, with the and the bbPress plugin active there being an “Interesting Stuff” forum created, as well as an “Enqueue Foo” plugin active that does the following:
Attempting to validate a singular forum page at
/forums/forum/interesting-stuff/amp/
results in the following difference with this PR:Instead of scripts being unexpectedly attributed to
wp-includes
:wp_editor()
, the editor scripts are now attributed to the plugin that caused them to be added. Fixes Site scanner Inconsistencies. #6668.Checklist