[2.1] Set amp-wp-unknown-size class and object-fit=contain for videos with unknown dimensions
#6578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierlon
approved these changes
Aug 30, 2021
.| @@ -4,7 +4,8 @@ | |||
| * width such as in the post content so that the contents do not get stretched or cropped. | |||
| * See <https://github.com/ampproject/amphtml/issues/21371#issuecomment-475443219>. | |||
| */ | |||
| .amp-wp-enforced-sizes { | |||
| .amp-wp-enforced-sizes, | |||
| .amp-wp-unknown-size { | |||
Codecov Report
@@ Coverage Diff @@
## 2.1 #6578 +/- ##
=========================================
Coverage 75.70% 75.70%
- Complexity 5918 5921 +3
=========================================
Files 237 237
Lines 17928 17931 +3
=========================================
+ Hits 13572 13575 +3
Misses 4356 4356
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Plugin builds for 807cf9b are ready 🛎️!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #6576 (for #6571) into the 2.1 branch, with the one addition of 41f6fbe which came originally from #6518.