Add support for custom non-AMP scripts#6528

Merged

westonruter merged 29 commits intodevelopfrom add/custom-script-allowance

Aug 19, 2021

+819-112

Commits on Aug 17, 2021

WIP: Start to allow script sanitizer to actually sanitize scripts
westonruter
committed
Prevent unwrapping noscript elements when there were scripts kept.
westonruter
committed
Use sanitize_scripts as sanitizer arg; remove obsolete todos
westonruter
committed
Add sanitization of event handler attributes
westonruter
committed
Prevent including AMP event handlers as custom event handlers
westonruter
committed
Remove sanitizing JSON scripts in script sanitizer
westonruter
committed
Catch MaxCssByteCountExceeded exception when attempting to set style attr
westonruter
committed
Update amp-toolbox-php to ampproject/amp-toolbox-php#319
westonruter
committed
Add style sanitizer arg to skip_tree_shaking
westonruter
committed
Prevent enforcing CSS max byte count on dev mode documents
westonruter
committed
Run AMP_Script_Sanitizer first
westonruter
committed
Prevent false positive event handler attribute detection with amp-position-observer@once and amp-font@on-* attrs
westonruter
committed
Make amp-position-observer and amp-font attribute exceptions more specific
westonruter
committed
Turn off tree shaking in style sanitizer when script sanitizer keeps custom scripts
westonruter
committed
Defer gathering selector conversion mappings until sanitizing
westonruter
committed
Add titles for script sanitizer error codes
westonruter
committed
Fix commit ref for ampproject/amp-toolbox
westonruter
committed
Run composer update
westonruter
committed
Include script basename in external script error title
westonruter
committed
Add todos
westonruter
committed
Use native img when custom scripts are kept
westonruter
committed
Allow native post forms when custom scripts are kept
westonruter
committed
Fix omission of amp-form script given native_post_forms_allowed arg can be dynamically set by style sanitizer
westonruter
committed

Commits on Aug 19, 2021

Avoid false positive sanitization of non-JS scripts
westonruter
committed
Use FQCN in docblock
pierlon
authored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for custom non-AMP scripts#6528

Commits on Aug 17, 2021

WIP: Start to allow script sanitizer to actually sanitize scripts

Prevent unwrapping `noscript` elements when there were scripts kept.

Use sanitize_scripts as sanitizer arg; remove obsolete todos

Add sanitization of event handler attributes

Prevent including AMP event handlers as custom event handlers

Remove sanitizing JSON scripts in script sanitizer

Catch MaxCssByteCountExceeded exception when attempting to set style attr

Update amp-toolbox-php to ampproject/amp-toolbox-php#319

Add style sanitizer arg to skip_tree_shaking

Prevent enforcing CSS max byte count on dev mode documents

Run AMP_Script_Sanitizer first

Prevent false positive event handler attribute detection with `amp-position-observer@once` and `amp-font@on-*` attrs

Make amp-position-observer and amp-font attribute exceptions more specific

Turn off tree shaking in style sanitizer when script sanitizer keeps custom scripts

Defer gathering selector conversion mappings until sanitizing

Add titles for script sanitizer error codes

Fix commit ref for ampproject/amp-toolbox

Run composer update

Include script basename in external script error title

Add todos

Use native img when custom scripts are kept

Allow native post forms when custom scripts are kept

Fix omission of amp-form script given native_post_forms_allowed arg can be dynamically set by style sanitizer

Commits on Aug 18, 2021

Improve PHP comments

Improve test coverage

Rename sanitize_script_elements() back to sanitize_js_script_elements()

Rename sanitize_scripts arg to sanitize_js_scripts

Commits on Aug 19, 2021

Avoid false positive sanitization of non-JS scripts

Use FQCN in docblock