-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove amp-fit-text block setting #5729
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5729 +/- ##
=============================================
+ Coverage 74.14% 74.22% +0.08%
Complexity 5498 5498
=============================================
Files 201 201
Lines 16653 16623 -30
=============================================
- Hits 12347 12339 -8
+ Misses 4306 4284 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Plugin builds for 015bb11 are ready 🛎️!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion.
Co-authored-by: John Watkins <[email protected]>
Co-authored-by: John Watkins <[email protected]>
Granted, there are probably no instances (or very few instances) of these blocks being used with fit-text. |
No, it should be be able to deprecate gracefully without any errors. I'll take a look at the example you provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #5729 (comment)
I've fixed the issue in bdb65aa. The |
Fixed indeed! Input: <!-- wp:paragraph {"ampFitText":true} -->
<amp-fit-text layout="fixed-height" min-font-size="4" max-font-size="172" height="172"><p>paragraph</p></amp-fit-text>
<!-- /wp:paragraph -->
<!-- wp:heading {"ampFitText":true} -->
<amp-fit-text layout="fixed-height" min-font-size="4" max-font-size="172" height="172"><h2>teasdasd</h2></amp-fit-text>
<!-- /wp:heading -->
<!-- wp:code {"ampFitText":true} -->
<amp-fit-text layout="fixed-height" min-font-size="4" max-font-size="172" height="172"><pre class="wp-block-code"><code>test</code></pre></amp-fit-text>
<!-- /wp:code -->
<!-- wp:quote {"ampFitText":true} -->
<amp-fit-text layout="fixed-height" min-font-size="5" max-font-size="73" height="90"><blockquote class="wp-block-quote"><p>quote</p></blockquote></amp-fit-text>
<!-- /wp:quote --> Output: <!-- wp:paragraph -->
<p>paragraph</p>
<!-- /wp:paragraph -->
<!-- wp:heading -->
<h2>teasdasd</h2>
<!-- /wp:heading -->
<!-- wp:code -->
<pre class="wp-block-code"><code>test</code></pre>
<!-- /wp:code -->
<!-- wp:quote -->
<blockquote class="wp-block-quote"><p>quote</p></blockquote>
<!-- /wp:quote --> No block validation errors: |
@pierlon Question: Is there a reason why you went with |
The |
Summary
Removes the
amp-fit-text
setting and related controls from the block panel and also removes the related block attributes from text blocks that had the setting enabled.Fixes #4557
Checklist