Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PreloadHeroImage Optimizer transformer #5350

Merged
merged 98 commits into from
Nov 3, 2020
Merged

Add PreloadHeroImage Optimizer transformer #5350

merged 98 commits into from
Nov 3, 2020

Commits on Aug 27, 2020

  1. Add initial scaffold for preload hero image transformer

    @schlessera
    schlessera committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    9706741 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Merge branch 'develop' into add/5055-hero-images

    @schlessera
    schlessera committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    53dc56a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Add HeroImage value object

    @schlessera
    schlessera committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    437fa8d View commit details
    Browse the repository at this point in the history

  2. Add missing attributes

    @schlessera
    schlessera committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    b268cd6 View commit details
    Browse the repository at this point in the history

  3. Add Amp::isTemplate check

    @schlessera
    schlessera committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    72a01b5 View commit details
    Browse the repository at this point in the history

  4. Complete first iteration of the code

    @schlessera
    schlessera committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    99eec9b View commit details
    Browse the repository at this point in the history

  5. Add tests for Amp::isTemplate()

    @schlessera
    schlessera committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    4d462af View commit details
    Browse the repository at this point in the history

  6. Use Extension class constants

    @schlessera
    schlessera committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    3a98ad0 View commit details
    Browse the repository at this point in the history

  7. Hook up spec test suite for PreloadHeroImage

    @schlessera
    schlessera committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    d8b2015 View commit details
    Browse the repository at this point in the history

  8. Add image URL validation

    @schlessera
    schlessera committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    0b78bd7 View commit details
    Browse the repository at this point in the history

  9. Fix PHPStan issues

    @schlessera
    schlessera committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    4c4bc56 View commit details
    Browse the repository at this point in the history

  10. Fix code style issues

    @schlessera
    schlessera committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    9703ebd View commit details
    Browse the repository at this point in the history

  11. Check for existing preloads

    @schlessera
    schlessera committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    4f1426b View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Merge branch 'develop' into add/5055-hero-images

    @schlessera
    schlessera committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    96f88ab View commit details
    Browse the repository at this point in the history

  2. Extract isValidImageSrc into separate Url helper

    @schlessera
    schlessera committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    fcbcc4a View commit details
    Browse the repository at this point in the history

  3. Add test for Amp::iAmpStory()

    @schlessera
    schlessera committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    16dbf2a View commit details
    Browse the repository at this point in the history

  4. Extract isAmpIframe() into Amp helper class

    @schlessera
    schlessera committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    8795fde View commit details
    Browse the repository at this point in the history

  5. Add preloadHeroImage configuration key

    @schlessera
    schlessera committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    d46c44e View commit details
    Browse the repository at this point in the history

  6. Add TooManyHeroImages error

    @schlessera
    schlessera committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    d97d49c View commit details
    Browse the repository at this point in the history

  7. Add CannotPreloadImage error

    @schlessera
    schlessera committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    e850726 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Video posters should not have SSRed images

    @schlessera
    schlessera committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    8cfadb1 View commit details
    Browse the repository at this point in the history

  2. Fix srcset assignment

    @schlessera
    schlessera committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    51da2cd View commit details
    Browse the repository at this point in the history

  3. Fix negated comparisons

    @schlessera
    schlessera committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    111e497 View commit details
    Browse the repository at this point in the history

  4. Add documentation for PreloadHeroImage transformer

    @schlessera
    schlessera committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    a0dc9cc View commit details
    Browse the repository at this point in the history

  5. Add test for throwing error at max data-hero

    @schlessera
    schlessera committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    1acb66f View commit details
    Browse the repository at this point in the history

  6. Add tests for throwing srcset error

    @schlessera
    schlessera committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    7c32636 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Remove <noscript> fallback image when adding SSR'ed image 

    Co-authored-by: Weston Ruter <[email protected]>
    @schlessera @westonruter
    schlessera and westonruter authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    7af1c5b View commit details
    Browse the repository at this point in the history

  2. Only continue to next parent when both dimensions are missing

    @schlessera
    schlessera committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    cbb01a1 View commit details
    Browse the repository at this point in the history

  3. Limit amount of parent traversal to be done when looking for dimensions

    @schlessera
    schlessera committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    ae4b1bd View commit details
    Browse the repository at this point in the history

  4. Skip "auto" dimensions

    @schlessera
    schlessera committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    86f34ef View commit details
    Browse the repository at this point in the history

  5. Add relative URL tests

    @schlessera
    schlessera committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    a4f2ec4 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2020

  1. Merge branch 'develop' into add/5055-hero-images

    @schlessera
    schlessera committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    361efde View commit details
    Browse the repository at this point in the history

  2. Extract ImageDimensions into separate class

    @schlessera
    schlessera committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    71d5170 View commit details
    Browse the repository at this point in the history

  3. Fix typehint for threshold

    @schlessera
    schlessera committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    e98e684 View commit details
    Browse the repository at this point in the history

  4. Add DIV to Tag constants

    @schlessera
    schlessera committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    56804ea View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Merge branch 'develop' into add/5055-hero-images

    @schlessera
    schlessera committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    d890f2e View commit details
    Browse the repository at this point in the history

  2. Let ImageDimensions store floats and strings

    @schlessera
    schlessera committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    034e724 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Use auto width for fixed height in tests

    @schlessera
    schlessera committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    0a07090 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Merge branch 'develop' into add/5055-hero-images

    @schlessera
    schlessera committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    b05b035 View commit details
    Browse the repository at this point in the history

  2. AMP Stories can accept SSR images as well now

    @schlessera
    schlessera committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    0ab477e View commit details
    Browse the repository at this point in the history

  3. Change viewport caching todo into a comment

    @schlessera
    schlessera committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    3850c25 View commit details
    Browse the repository at this point in the history

  4. Use attribute constant for viewport 

    Co-authored-by: Pierre Gordon <[email protected]>
    @schlessera @pierlon
    schlessera and pierlon authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    b71afe8 View commit details
    Browse the repository at this point in the history

  5. Use constants for checking viewport 

    Co-authored-by: Pierre Gordon <[email protected]>
    @schlessera @pierlon
    schlessera and pierlon authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    122a5a0 View commit details
    Browse the repository at this point in the history

  6. Use attribute constant for viewport name

    @schlessera
    schlessera committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    392709c View commit details
    Browse the repository at this point in the history

  7. Fix userpass and host order 

    Co-authored-by: Pierre Gordon <[email protected]>
    @schlessera @pierlon
    schlessera and pierlon authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    025d54b View commit details
    Browse the repository at this point in the history

  8. Fix typo in docblock 

    Co-authored-by: Pierre Gordon <[email protected]>
    @schlessera @pierlon
    schlessera and pierlon authored Sep 23, 2020
    Configuration menu
    Copy the full SHA
    e68f7ff View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Make CannotPreloadImage work without element

    @schlessera
    schlessera committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    9b58169 View commit details
    Browse the repository at this point in the history

  2. Add more tests for PreloadHeroImage transformer

    @schlessera
    schlessera committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    b0ed9ba View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into add/5055-hero-images

    @schlessera
    schlessera committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    b6033c2 View commit details
    Browse the repository at this point in the history

  4. Remove unused check for amp-story

    @schlessera
    schlessera committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    c251909 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. Merge branch 'develop' into add/5055-hero-images

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    d35b8a8 View commit details
    Browse the repository at this point in the history

  2. Update spec tests

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    d1ba9c7 View commit details
    Browse the repository at this point in the history

  3. Check amp-anim for placeholders as well

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    fba400f View commit details
    Browse the repository at this point in the history

  4. Fix bug in placeholder detection

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    7afa02b View commit details
    Browse the repository at this point in the history

  5. Fix typos in tests

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    a6c1a89 View commit details
    Browse the repository at this point in the history

  6. Fix order of preload link additions

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    1169981 View commit details
    Browse the repository at this point in the history

  7. Fix srcset preload test

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    8eb3250 View commit details
    Browse the repository at this point in the history

  8. Add 2nd image to test noscript in AMP_Theme_Support tests

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    ea637d5 View commit details
    Browse the repository at this point in the history

  9. Allow for more embeds to preload their placeholders

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    6ae3e3e View commit details
    Browse the repository at this point in the history

  10. Add tests for Youtube placeholder

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    a981eeb View commit details
    Browse the repository at this point in the history

  11. Use any descendant image of a placeholder for preloading

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    7309ee3 View commit details
    Browse the repository at this point in the history

  12. Add test for descendant amp-img and img tags

    @schlessera
    schlessera committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    dda3065 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Make noscript fetching account for descendants

    @schlessera
    schlessera committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    6caab91 View commit details
    Browse the repository at this point in the history

  2. Introduce constant for noscript>img query

    @schlessera
    schlessera committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    17380a7 View commit details
    Browse the repository at this point in the history

  3. Add DetermineHeroImages transformer in plugin

    @schlessera
    schlessera committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    607fa5d View commit details
    Browse the repository at this point in the history

  4. Add support for CSS background-image property

    @schlessera
    schlessera committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    6343103 View commit details
    Browse the repository at this point in the history

  5. Support data-amp-original-style for fetching background-image URL

    @schlessera
    schlessera committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    d4465a4 View commit details
    Browse the repository at this point in the history

  6. Improve transformer docblock

    @schlessera
    schlessera committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    ec6daca View commit details
    Browse the repository at this point in the history

  7. Add missing trailing comma

    @schlessera
    schlessera committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    a56f7c1 View commit details
    Browse the repository at this point in the history

  8. Revert priority change again

    @schlessera
    schlessera committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    29daf74 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Add site icon detection

    @schlessera
    schlessera committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    1555c72 View commit details
    Browse the repository at this point in the history

  2. Use constants for response destinations

    @schlessera
    schlessera committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    07689ad View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Add experimental srcset support

    @schlessera
    schlessera committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    27d3be6 View commit details
    Browse the repository at this point in the history

  2. Add featured image detection

    @schlessera
    schlessera committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    30973c6 View commit details
    Browse the repository at this point in the history

  3. Add featured image detection

    @schlessera
    schlessera committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    e47cb8f View commit details
    Browse the repository at this point in the history

  4. Switch off srcset preloading

    @schlessera
    schlessera committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    2bd673f View commit details
    Browse the repository at this point in the history

  5. Copy ErrorComparison over into the plugin tests

    @schlessera
    schlessera committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    a92b8c1 View commit details
    Browse the repository at this point in the history

  6. Add tests for DetermineHeroImages

    @schlessera
    schlessera committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    9addb67 View commit details
    Browse the repository at this point in the history

  7. Make isTiny depend on height for layout::FIXED_HEIGHT

    @schlessera
    schlessera committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    60abe7a View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into add/5055-hero-images

    @schlessera
    schlessera committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    c249d69 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2020

  1. Extract xpath queries intro constants

    @schlessera
    schlessera committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    a146319 View commit details
    Browse the repository at this point in the history

  2. Take pre-existing data-hero elements into account

    @schlessera
    schlessera committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    7ba627e View commit details
    Browse the repository at this point in the history

  3. Add tests for pre-existing hero images

    @schlessera
    schlessera committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    01b33e0 View commit details
    Browse the repository at this point in the history

  4. Only look for hero image candidates that are not already tagged as he… 

    …ro images
    @schlessera
    schlessera committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    cdb8818 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2020

  1. Allow for the embed element itself to have a background image 

    Co-authored-by: Weston Ruter <[email protected]>
    @schlessera @westonruter
    schlessera and westonruter authored Oct 31, 2020
    Configuration menu
    Copy the full SHA
    a856eb1 View commit details
    Browse the repository at this point in the history

  2. Allow regular image in anticipation of AMP change 

    Co-authored-by: Weston Ruter <[email protected]>
    @schlessera @westonruter
    schlessera and westonruter authored Oct 31, 2020
    Configuration menu
    Copy the full SHA
    1eed7f1 View commit details
    Browse the repository at this point in the history

  3. Grammatify correctlier 

    Co-authored-by: Weston Ruter <[email protected]>
    @schlessera @westonruter
    schlessera and westonruter authored Oct 31, 2020
    Configuration menu
    Copy the full SHA
    332ad51 View commit details
    Browse the repository at this point in the history

  4. Append pass instead of replacing entire user string 

    Co-authored-by: Weston Ruter <[email protected]>
    @schlessera @westonruter
    schlessera and westonruter authored Oct 31, 2020
    Configuration menu
    Copy the full SHA
    d41fab7 View commit details
    Browse the repository at this point in the history

  5. Rename ResponseDestination into RequestDestination

    @schlessera
    schlessera committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    ce95088 View commit details
    Browse the repository at this point in the history

  6. Rename isValidImageUrl into isValidNonDataUrl

    @schlessera
    schlessera committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    a7ac118 View commit details
    Browse the repository at this point in the history

  7. Rename expected_errors into expectedErrors

    @schlessera
    schlessera committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    3320b6f View commit details
    Browse the repository at this point in the history

  8. Remove useless TODO

    @schlessera
    schlessera committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    6ee3b0a View commit details
    Browse the repository at this point in the history

  9. Correct equal sign alignment 

    Co-authored-by: Weston Ruter <[email protected]>
    @schlessera @westonruter
    schlessera and westonruter authored Oct 31, 2020
    Configuration menu
    Copy the full SHA
    910342c View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. Rename site icon int ocustom logo

    @schlessera
    schlessera committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    b2f67a6 View commit details
    Browse the repository at this point in the history

  2. Add configuration key for srcset preloading

    @schlessera
    schlessera committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    94f4259 View commit details
    Browse the repository at this point in the history

  3. Adapt isValidImageSrc tests to isValidNonDataUrl

    @schlessera
    schlessera committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    5270af3 View commit details
    Browse the repository at this point in the history

  4. Ensure src is valid non-data URL

    @schlessera
    schlessera committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    ec5584f View commit details
    Browse the repository at this point in the history

  5. Fix missing renames for ResponseDestination -> RequestDestination

    @schlessera
    schlessera committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    981e960 View commit details
    Browse the repository at this point in the history