Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor URL validation CLI script to make parts reusable #5306

Merged
merged 49 commits into from
Nov 23, 2020
Merged

Refactor URL validation CLI script to make parts reusable #5306

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
717ce36
Refactor URL validation CLI script
johnwatkins0 Aug 31, 2020
6c3a318
URL validation: return WP_Error if validity is an error
johnwatkins0 Sep 1, 2020
4a069f4
Use with_lock where method is called instead of inside method
johnwatkins0 Sep 1, 2020
47f22c8
Minor updates primarily in formatting and comments
johnwatkins0 Oct 6, 2020
640d6b6
Use get_flag_value in CLI script to handle assoc args
johnwatkins0 Oct 7, 2020
9661bec
PHPCS fixes
johnwatkins0 Oct 7, 2020
be19b24
Merge branch 'feature/refactor-url-validation' of https://github.com/…
johnwatkins0 Oct 7, 2020
1cf083d
Fix CLI script imports
johnwatkins0 Oct 7, 2020
8b6099c
Use option instead of transient for locking
johnwatkins0 Oct 7, 2020
fdcc5f0
Rename ValidationURLProvider
johnwatkins0 Oct 7, 2020
4ff12fd
Make class properties private
johnwatkins0 Oct 7, 2020
39c1665
Trim outdated comment content
johnwatkins0 Oct 7, 2020
cdbad7a
Remove unneeded use
johnwatkins0 Oct 7, 2020
14c4d62
Remove test code
johnwatkins0 Oct 7, 2020
98bd4b2
Merge remote-tracking branch 'origin/develop' into feature/refactor-u…
johnwatkins0 Oct 7, 2020
60db6fa
Try importing WP_CLI\Utils
schlessera Oct 7, 2020
2608783
Merge remote-tracking branch 'origin/develop' into feature/refactor-u…
johnwatkins0 Oct 13, 2020
2ccffb3
Include cli utils in autoload-dev
johnwatkins0 Oct 19, 2020
ebdc0e7
Merge remote-tracking branch 'origin/develop' into feature/refactor-u…
johnwatkins0 Oct 21, 2020
b569341
Remove cli utils from autoload-dev
johnwatkins0 Oct 21, 2020
e7c12f2
Fix with_lock unit tests
johnwatkins0 Oct 21, 2020
5ee7d42
Apply suggestions from code review
johnwatkins0 Oct 28, 2020
58bacd0
Replace obsolete class property with get_flag_value call
johnwatkins0 Oct 28, 2020
050b1e7
Make validity_by_type class property private and add getter method
johnwatkins0 Oct 28, 2020
457d145
ScannableURLProvider: return limit_per_type # of taxonomy links by de…
johnwatkins0 Oct 28, 2020
5893cfb
Add omitted property
johnwatkins0 Oct 28, 2020
9559058
Undo use of assertIsString
johnwatkins0 Oct 28, 2020
d1e3bde
PHPStan ignore a line
johnwatkins0 Oct 29, 2020
fbc39a6
Update lock file
johnwatkins0 Oct 29, 2020
3071784
Merge remote-tracking branch 'origin/develop' into feature/refactor-u…
johnwatkins0 Oct 29, 2020
1e8ec58
Merge remote-tracking branch 'origin/develop' into feature/refactor-u…
johnwatkins0 Nov 10, 2020
3c7d7d7
Simplify test assertion
johnwatkins0 Nov 10, 2020
e70f816
Improve coverage with more @covers comments
johnwatkins0 Nov 10, 2020
c4899a7
Update covers comment style
johnwatkins0 Nov 10, 2020
6c449c0
PHPCS fix
johnwatkins0 Nov 10, 2020
4c0238d
Rename class properties to match the classes they're instances of
johnwatkins0 Nov 11, 2020
6f42fd3
Add stub for wp cli function to avoid phpstan ignore comment
johnwatkins0 Nov 11, 2020
bf19d97
Add parentheses to function in covers tag
johnwatkins0 Nov 11, 2020
90eb92c
Merge branch 'develop' of github.com:ampproject/amp-wp into feature/r…
westonruter Nov 21, 2020
de33111
Combine redundant calls to get_urls method
johnwatkins0 Nov 23, 2020
f185379
Fix for line inadvertently placed in conditional
johnwatkins0 Nov 23, 2020
cc3c949
Formatting fixes
johnwatkins0 Nov 23, 2020
d87ad9d
Eliminate the use of a flag in validate URL function
johnwatkins0 Nov 23, 2020
e34d6f5
Add leading slash to unnamespaced class used within namespace
johnwatkins0 Nov 23, 2020
2e48427
Convert ValidationRequestMocking into trait
johnwatkins0 Nov 23, 2020
7fcf1ac
Merge branch 'feature/refactor-url-validation' of https://github.com/…
johnwatkins0 Nov 23, 2020
8ea22d6
Reset lock timeout from inside CLI script
johnwatkins0 Nov 23, 2020
13917b3
Eliminate lock timeout filter
johnwatkins0 Nov 23, 2020
9c627b3
PHPCS fix
johnwatkins0 Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading