Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: move close button to the top in mobile view #5211

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

johnwatkins0
Copy link
Contributor

Summary

This fixes #5193 by moving the wizard's "Close" button to the top right of the screen at mobile widths. This opens up space for the other buttons, particularly on the final screen in reader mode, where the "Customize" button was being pushed to the right.

Before After
before before

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@google-cla google-cla bot added the cla: yes Signed the Google CLA label Aug 10, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2020

Plugin builds for 076d826 are ready 🛎️!

@westonruter
Copy link
Member

@johnwatkins0 Should the margins be equalized? Right now the right margin is 16px whereas the top margin is 8px on the button:

image

That would make the “Close” text more equidistant from the top and right.

@westonruter
Copy link
Member

In other words, add margin: 8px or margin-right: 8px for the Close button.

@johnwatkins0
Copy link
Contributor Author

In other words, add margin: 8px or margin-right: 8px for the Close button.

@westonruter Adjusted the padding in 076d826, but since you mentioned margin I might be misinterpreting. Let me know if it looks better to you now.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I should have said padding instead of margin.

@westonruter westonruter merged commit 86c3daf into develop Aug 10, 2020
@westonruter westonruter deleted the fix/5193-wizard-button-spacing branch August 10, 2020 22:15
@westonruter westonruter added this to the v2.0 milestone Aug 10, 2020
@johnwatkins0 johnwatkins0 added the WS:UX Work stream for UX/Front-end label Aug 12, 2020
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. cla: yes Signed the Google CLA WS:UX Work stream for UX/Front-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not enough space for buttons in onboarding wizard
2 participants