-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent sanitization of Customizer preview styles #4977
Prevent sanitization of Customizer preview styles #4977
Conversation
@westonruter Do you think this PR also include the prevention of CSS tree shaking when the sanititization argument |
Plugin builds for 9dd7976 are ready 🛎️!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something else we need to address is how the Customizer preview handles (or doesn't currently) the addition of a header video in Twenty Seventeen. Currently a YouTube video just fails to show up, and an MP4 is positioned in the wrong spot. We need to make sure that the header_video
and external_header_video
settings get a transport
assigned of refresh
as opposed to postMessage
to deal with this. I'll address this as part of #4984.
(E2E tests failing is a known issue to be fixed by #4980.) |
Summary
When the site is being previewed in the Customizer:
data-ampdevmode
attribute to scripts so that they are ignored by sanitizersdata-ampdevmode
attribute to all dependencies of thecustomizer-preview
style handle, including itselfallow_dirty_styles
andallow_dirty_scripts
sanitizer args from the codebase as they are no longer being used anywhereFixes #4804.
Checklist