Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure save screen has all option data #4973

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

johnwatkins0
Copy link
Contributor

Summary

Fixes #4971

This fixes a bug @westonruter brought up on Slack where the save screen sometimes doesn't have all data. This was because one portion of the screen was using the updates object from the options state. updates only contains options updated in the current session. This came about during an intermediate stage of development, and later on most instances of updates needed to be changed to editedOptions, which contains the original fetched options with updates applied. I missed this one earlier.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@johnwatkins0 johnwatkins0 requested a review from westonruter July 2, 2020 05:41
@googlebot googlebot added the cla: yes Signed the Google CLA label Jul 2, 2020
@westonruter westonruter added this to the v1.6 milestone Jul 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2020

Plugin builds for 719ff5c are ready 🛎️!

@westonruter
Copy link
Member

E2E is failing for some reason:

  ● Done › renders transitional mode done screen
    TimeoutError: waiting for selector ".technical-background" failed: timeout 3000ms exceeded
      20 | 	await visitAdminPage( 'admin.php', 'page=amp-setup' );
      21 | 	await clickNextButton();
    > 22 | 	await page.waitForSelector( '.technical-background' );
         | 	           ^
      23 | }
      24 | 
      25 | export async function moveToTemplateModeScreen( { technical } ) {

But this is also failing in develop.

@westonruter westonruter merged commit a8a4d4d into develop Jul 2, 2020
@westonruter westonruter deleted the feature/4707-done-screen branch July 2, 2020 06:09
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 17, 2020
@johnwatkins0 johnwatkins0 added the WS:UX Work stream for UX/Front-end label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. cla: yes Signed the Google CLA WS:UX Work stream for UX/Front-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard: Done screen doesn't show expected state when previous selections were retained
3 participants