Ensure save screen has all option data #4973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4971
This fixes a bug @westonruter brought up on Slack where the save screen sometimes doesn't have all data. This was because one portion of the screen was using the
updates
object from the options state.updates
only contains options updated in the current session. This came about during an intermediate stage of development, and later on most instances ofupdates
needed to be changed toeditedOptions
, which contains the original fetched options with updates applied. I missed this one earlier.Checklist