Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README.md file #4613

Merged
merged 6 commits into from
Apr 23, 2020
Merged

Add README.md file #4613

merged 6 commits into from
Apr 23, 2020

Conversation

schlessera
Copy link
Collaborator

@schlessera schlessera commented Apr 21, 2020

Summary

Add a README.md file to the library within the lib/optimizer subfolder that documents the Optimizer library and its usage.

Fixes #4216

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Apr 21, 2020
@schlessera schlessera added Documentation Documentation related tasks Optimizer labels Apr 21, 2020
@schlessera schlessera modified the milestone: Sprint 27 Apr 21, 2020
@schlessera schlessera marked this pull request as ready for review April 21, 2020 07:19
@westonruter
Copy link
Member

Depends on #4614 correct?

@schlessera
Copy link
Collaborator Author

Failing unrelated test to download data for <amp-hulu>...

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

…izer-documentation

* 'develop' of github.com:ampproject/amp-wp: (71 commits)
  Fix broken test about link ordering after optimization
  Remove Configurable interface from schema transformer
  Add tests for dependency resolution
  Use reflection to detect dependencies in correct order
  Fix broken tests
  Add `null` type information where applicable
  Fix grammar typo
  Swap required order of configuration and remote erequest objects
  Replace copypasta in filesystem transport
  Replace reference to Go filename
  Make configuration argument optional for transformation engine
  Bump CSS cache version
  Update composer.lock
  Use patch file instead of diff
  Update patch: Fix parsing CSS selectors which contain commas
  Update php-css-parser to dev-master#bc6ec74; remove patches/php-css-parser-138-extended.patch
  Add test to demonstrate failure to parse class names containing escaped fractions
  Restrict metaboxes which appear on the validated URL screen
  Update hook priority in test_add_admin_hooks
  Restrict row actions for taxonomy terms
  ...
@westonruter westonruter merged commit 83aaea8 into develop Apr 23, 2020
@westonruter westonruter deleted the add-optimizer-documentation branch April 23, 2020 21:36
@westonruter westonruter added this to the v1.6 milestone Jun 2, 2020
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 17, 2020
@schlessera schlessera added the WS:Perf Work stream for Metrics, Performance and Optimizer label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. cla: yes Signed the Google CLA Documentation Documentation related tasks Optimizer WS:Perf Work stream for Metrics, Performance and Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for optimizer libs
3 participants