Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

ampproject / amp-wp Public

Notifications You must be signed in to change notification settings
Fork 384
Star 1.8k

Code
Issues 17
Pull requests 35
Discussions
Actions
Projects 1
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

Prevent validation errors for URLs with leading or trailing spaces#4166

Merged

westonruter merged 9 commits intodevelopampproject/amp-wp:developfrom fix/href-validationampproject/amp-wp:fix/href-validationCopy head branch name to clipboard

Jan 24, 2020

+233-11

Conversation Commits9 (9)Checks Files changed

Commits

Commits on Jan 23, 2020

Allow a URL to have a leading space without a validation error
kienstra
committed
Replace 2 calls of trim() with longer regex in parse_protocol()
kienstra
committed
As there's now a capturing group, remove lookahead
kienstra
committed
Revert change to regex, in favor of trimming before it's passed
kienstra
committed
Move urldecode() lower in the function
kienstra
committed
Remove test case that is no longer handled
kienstra
committed

Commits on Jan 24, 2020

Add a new method to normalize URLs
kienstra
committed
Use suggested normalization, update tests
kienstra
committed
Revert change in some tests, as they're not needed anymore
kienstra
committed

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.