Address notice and console error in Paired Browsing from async #4163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent the warning from appearing, along with the console error: TypeError: Cannot read property 'domReady' of undefined.
|
Hi Weston, it looks like you saw this already, but this is ready for review whenever you have a chance. You're fast with seeing these 😄 |
westonruter
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Paired Browsing, this prevents the occasional notice and console error that Weston found, using his suggested fix.
Fixes #4127
Before
Sometimes, this would appear on a refresh with a cleared cache:
After
That issue didn't occur after refreshing 20 times.
Checklist