Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loading=lazy attribute from iframes #3941

Merged
merged 3 commits into from
Dec 17, 2019

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Dec 17, 2019

Summary

This PR removes the loading="lazy" attribute when sanitizing iframes as amp-iframe already has lazy loading built-in. All other values for the loading attribute are to result in validation errors.

Fixes #3939.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Dec 17, 2019
@pierlon pierlon requested a review from westonruter December 17, 2019 01:18
@westonruter westonruter added this to the v1.5 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent loading=lazy from being copied from iframe to amp-iframe since invalid (and built-in)
3 participants