For a Gallery block with a lightbox, allow viewing multiple images in the lightbox #3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the [gallery] shortcode, use the simpler recommendation: ampproject/amphtml#25021 (comment)
|
Request For Review Hi @westonruter, There are testing steps in the issue for when this is ready for QA. Thanks, Weston! |
westonruter
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a Gallery block with a lightbox, this enables viewing multiple images in the lightbox:
To do this, it uses the amp-lightbox-gallery instead of
amp-image-lightbox.This is a similar change to that in the gallery shortcode.
Fixes #2849
Checklist