Remove maximum-scale=1 and user-scalable=no from Reader template meta viewport #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
the
Accessibility
|
Thanks for the quick fix @westonruter! |
swissspidy
approved these changes
Nov 4, 2019
westonruter
force-pushed
the
fix/reader-template-meta-viewport-a11y
branch
from
207c579 to
6438f48
Compare
|
Approved Hi @westonruter, The Reader template still looks good:
|
kienstra
approved these changes
Nov 4, 2019
|
Merging in spite of the unrelated E2E test failure. |
|
Cherry-picked into the |
westonruter
added a commit
that referenced
this pull request
Nov 5, 2019
3 tasks
westonruter
added a commit
that referenced
this pull request
Nov 5, 2019
westonruter
added a commit
that referenced
this pull request
Nov 5, 2019
|
Steps To Test
|
|
Verified in QA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reader mode templates includes
maximum-scale=1anduser-scalable=noin the meta viewport. This was pointed out by @rianrietveld as being a critical accessibility issue since it prevents users from being able to zoom to read text. AMP has no requirement to have these meta viewport properties. The bare minimum AMP requires is just havingdevice-widthdefined.Note that this issue only applied to the Reader mode templates; when using Standard or Transitional modes, the meta viewport is whatever the active theme is using, as long as it has the AMP-required
width=device-widthviewport property (which the AMP plugin will enforce).It used to be that AMP required these extra properties in the meta viewport. This was no longer the case as of 4 years ago: ampproject/amphtml#592. As a testament to how old the AMP plugin is, the meta viewport for the plugin was added a couple weeks before AMP removed the additional properties.
Update: See #3690 for also removing these meta viewport properties from the old v0.3 back-compat templates.