Account for filtering of gallery 'link' attribute

[kienstra]

Summary

This fixes a case where a gallery lightbox doesn't open, when adding a $atts['link'] = 'file' to a 'shortcode_atts_gallery' filter.

Addresses an edge case from issue #2850 (comment)

Steps to reproduce

1. Create a post
2. Add a Shortcode block
3. Enter a gallery, like:

[gallery ids="3762, 3470, 3327, 2877"]

4. Select 'Add lightbox effect'
5. Publish the post, and go to the front-end
6. Add this to a plugin:

add_filter(
	'shortcode_atts_gallery',
	function( $atts ) {
		$atts['link'] = 'file';
		return $atts;
	}
);

7. Reload the front-end
8. Expected: on clicking an image in the gallery, it opens a lightbox
9. Actual: it goes to the URL of the image:

Checklist

• My pull request is addressing an open issue (please create one otherwise).
• My code is tested and passes existing tests.
• My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

[kienstra]

When gallery_shortcode() runs, it's possible to filter the $attributes with the shortcode_atts_gallery filter.

And that can change the previous value of $attributes['link'] = 'none';, causing the lightbox to not work.

[kienstra]

Request For Review

Hi @westonruter,
Hope your Friday's off to a great start.

You've probably looked at the code at least a little, but could you please do a formal review?

It looks like this PR works for @rsmith4321:

I also tested the latest update and it seems to fix the issue with $attr['link'] = 'file';. I've added that back into my functions.php and the lightbox is working, thanks.

Thanks, Weston! Have a great weekend.

[kienstra]

Thanks, Weston!

[kienstra]

Question about moving to 'Ready for Merging'

Hi @westonruter,
Hope you had a great weekend.

Would it be alright to move this to 'Ready for Merging,' without traditional QA? The steps to reproduce include adding a PHP filter.

Thanks, Weston!

[westonruter]

Given it was already tested by the other Ryan, then yes, I moved it.

[kienstra]

Thanks, Weston!