Prevent tree-shaking CSS selectors for dynamic attributes #3212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue reported on the support forum:
In #1959 (and #2017, #2642, #2710) tree shaking for CSS selectors was made aware of the class names for AMP components which can be dynamically added/removed from a page. Even though the selector with such a class name may not exist at the initial time of rendering the page, the selector may very well apply later. The same logic needed to be extended to attributes which are added/removed to AMP components. In particular:
amp-sidebar
: Theopen
attribute is dynamically added when the sidebar is opened.amp-accordion
: Theexpanded
attribute is added when a section is opened by the user.amp-live-list
: Thedata-tombstone
attribute can appear in anamp-live-list
's contents during the life of a page.