Measure Code Coverage

.dev-lib

@@ -1,3 +1,5 @@
+#!/bin/bash
+
 DEFAULT_BASE_BRANCH=develop
 ASSETS_DIR=wp-assets
 PROJECT_SLUG=amp
@@ -26,3 +28,9 @@ function after_wp_install {
 		echo "done"
 	fi
 }
+
+function coverage_clover {
+	if [[ ! -z $RUN_PHPUNIT_COVERAGE ]]; then
+		echo --coverage-clover build/logs/clover.xml
+	fi
+}

.travis.yml

@@ -37,6 +37,9 @@ install:
   - export DEV_LIB_PATH=vendor/xwp/wp-dev-lib/scripts
   - source "$DEV_LIB_PATH/travis.install.sh"
 
+before_script:
+  - phpenv config-rm xdebug.ini || echo "xdebug.ini does not exist."
+
 script:
   - npm run build:js
   - source "$DEV_LIB_PATH/travis.script.sh"
@@ -48,12 +51,14 @@ jobs:
   fast_finish: true
   allow_failures:
     - stage: bleeding-edge
+    - stage: coverage
   include:
     - stage: lint
       name: Lint (PHP, JavaScript, and configuration files)
       php: "7.3"
       env: WP_VERSION=latest DEV_LIB_ONLY=phpsyntax
       before_script:
+        - phpenv config-rm xdebug.ini || echo "xdebug.ini does not exist."
         - composer require --dev localheinz/composer-normalize --ignore-platform-reqs
       script:
         - source "$DEV_LIB_PATH/travis.script.sh"
@@ -110,6 +115,20 @@ jobs:
       php: "7.3"
       env: WP_VERSION=trunk  DEV_LIB_ONLY=phpunit                               INSTALL_PWA_PLUGIN=1
 
+    - stage: coverage
+      name: PHP and JavaScript unit tests (7.3, WordPress trunk, with code coverage)
+      if: branch = develop
+      php: "7.3"
+      env: WP_VERSION=latest DEV_LIB_ONLY=phpunit                               INSTALL_PWA_PLUGIN=1 RUN_PHPUNIT_COVERAGE=1
+      before_script:
+        - echo "Running unit tests with code coverage..."
+      script:
+        - npm run build:js
+        - source "$DEV_LIB_PATH/travis.script.sh"
+        - bash <(curl -s https://codecov.io/bash) -cF php -f /tmp/wordpress/src/wp-content/plugins/amp/build/logs/clover.xml
+        - npm run test:js -- --collectCoverage
+        - bash <(curl -s https://codecov.io/bash) -cF javascript -f build/logs/lcov.info
+
     - stage: deploy
       if: type = push AND fork = false AND ( branch =~ ^[a-z][a-z0-9-]{0,10}$ OR branch =~ ^[0-9]+\.[0-9]+$ ) AND NOT branch IN ( live, test, dev, settings, team, support, debug, multidev, files, tags, billing )
       php: "7.1"

Gruntfile.js

@@ -88,7 +88,7 @@ module.exports = function( grunt ) {
 			const versionAppend = new Date().toISOString().replace( /\.\d+/, '' ).replace( /-|:/g, '' ) + '-' + commitHash;
 
 			const paths = lsOutput.trim().split( /\n/ ).filter( function( file ) {
-				return ! /^(blocks|\.|bin|([^/]+)+\.(md|json|xml)|Gruntfile\.js|postcss\.config\.js|tests|wp-assets|readme\.md|composer\..*|patches|webpack.*|assets\/src|docker-compose\.yml|babel\.config\.js)/.test( file );
+				return ! /^(blocks|\.|bin|([^/]+)+\.(md|json|xml)|Gruntfile\.js|postcss\.config\.js|tests|wp-assets|readme\.md|composer\..*|patches|webpack.*|assets\/src|docker-compose\.yml|babel\.config\.js|codecov\.yml)/.test( file );
 			} );
 
 			paths.push( 'vendor/autoload.php' );

amp.php

@@ -185,15 +185,24 @@ function _amp_show_load_errors_admin_notice() {
 // Abort if dependencies are not satisfied.
 if ( ! empty( $_amp_load_errors->errors ) ) {
 	add_action( 'admin_notices', '_amp_show_load_errors_admin_notice' );
-	if ( defined( 'WP_CLI' ) && WP_CLI ) {
+
+	if ( ( defined( 'WP_CLI' ) && WP_CLI ) || 'true' === getenv( 'CI' ) || 'cli' === PHP_SAPI ) {
 		$messages = array( __( 'AMP plugin unable to initialize.', 'amp' ) );
 		foreach ( array_keys( $_amp_load_errors->errors ) as $error_code ) {
 			$messages = array_merge( $messages, $_amp_load_errors->get_error_messages( $error_code ) );
 		}
 		$message = implode( "\n * ", $messages );
 		$message = str_replace( array( '<code>', '</code>' ), '`', $message );
+
+		if ( ! class_exists( 'WP_CLI' ) ) {
+			echo "$message\n"; // phpcs:disable WordPress.Security.EscapeOutput.OutputNotEscaped
+
+			exit( 1 );
+		}
+
 		WP_CLI::warning( $message );
 	}
+
 	return;
 }
 

codecov.yml

@@ -0,0 +1,12 @@
+coverage:
+  status:
+    patch: false
+    changes: false
+    project:
+      default:
+        target: auto
+
+comment: off
+
+ignore:
+  - "/bin"

tests/unit/jest.config.js

@@ -13,4 +13,7 @@ module.exports = {
 		'<rootDir>/build',
 		'.*/e2e/.*',
 	],
+	coveragePathIgnorePatterns: [ '/node_modules/', '<rootDir>/build/', '<rootDir>/assets/src/test/helpers/' ],
+	coverageReporters: [ 'lcov' ],
+	coverageDirectory: '<rootDir>/build/logs',
 };

tests/validation/test-class-amp-validated-url-post-type.php

@@ -1401,7 +1401,7 @@ public function test_filter_the_title_in_post_list_table() {
 	/**
 	 * Test render_post_filters.
 	 *
-	 * @covers \AMP_Validation_Error_Taxonomy::render_post_filters()
+	 * @covers \AMP_Validated_URL_Post_Type::render_post_filters()
 	 */
 	public function test_render_post_filters() {
 		set_current_screen( 'edit.php' );

tests/validation/test-class-amp-validation-error-taxonomy.php

@@ -513,7 +513,7 @@ public function test_filter_posts_where_for_validation_error_status() {
 	/**
 	 * Test summarize_validation_errors.
 	 *
-	 * @covers AMP_Validation_Manager::summarize_validation_errors()
+	 * @covers AMP_Validation_Error_Taxonomy::summarize_validation_errors()
 	 */
 	public function test_summarize_validation_errors() {
 		$attribute_node_name = 'button';