Add PRs and issues from the 1.0 milestone to the changelog #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly use PRs, except where there was extensive discussion on an issue. Most entries don't list the corresponding issue for a pull request. This is in reverse-chronological order. And it goes from the bottom up: https://github.com/Automattic/amp-wp/milestone/7?closed=1
Before, I had paraphrased some PR titles in the changelog. Other edits include wrapping HTML elements in `
To improve the dispaly in Markdown. Also, remove 'Gutenberg' from 'Gutenberg blocks.' It sounds like that name won't be present once it's merged into Core.
|
@kienstra instead of sorting in reverse chronological order, could they be generally sorted by importance? What I have in mind is something similar to the “what's new” posts for Gutenberg, for example: https://make.wordpress.org/core/2018/05/18/whats-new-in-gutenberg-18th-may/ |
|
Sounds good, @westonruter. I'll sort these by order of importance, like in the Gutenberg post you mentioned. |
With their relative importance in mind. Of course, this is subjective.
|
Hi @westonruter, |
|
Hey @kienstra, this makes my job easier and looks better than before! Thanks for this! 🎆 |
westonruter
approved these changes
Jun 9, 2018
…n forced by filter Fix notice of trying to get property of non-object
…sanitization impact term status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request For Review
Hi @westonruter,
Could you please review this update to the Changelog?
https://github.com/Automattic/amp-wp/milestone/7?closed=1
1.0. Maybe we could do that for the production release.Closes #1108.