Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-wp.org links is not helpful for end uses and is bad for SEO #6076

Closed
raja-anbazhagan opened this issue Apr 17, 2021 · 4 comments · Fixed by #6082
Closed

amp-wp.org links is not helpful for end uses and is bad for SEO #6076

raja-anbazhagan opened this issue Apr 17, 2021 · 4 comments · Fixed by #6082
Assignees
Labels
Bug Something isn't working Sanitizers WS:Core Work stream for Plugin core
Milestone

Comments

@raja-anbazhagan
Copy link

Bug Description

Check this screen shot.

AMP error help

This error message contains a link to https://amp-wp.org/?p=5463 Which I believe no end user would need or want to see.

Also It is also not good for a healthy SEO.

Expected Behaviour

No links that are irrelevant to the site should be visible for end user.

Steps to reproduce

  1. Open Chrome and navigate to "https://springhow.com" and open any recent post
  2. Open Chrome Developer tools and Go to network tab
  3. Add a Network request blocking for the pattern "https://springhow.com/wp-comments-post.php*"
  4. Now submit a comment And you will see an error as shown in the screenshot.

Additional context

  • WordPress version: 5.7.1
  • Plugin version: 2.0.11
  • Gutenberg plugin version (if applicable):
  • AMP plugin template mode: standard
  • PHP version: 7.3
  • OS: Debian
  • Browser: Chrome
  • Device: Windows

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@raja-anbazhagan raja-anbazhagan added the Bug Something isn't working label Apr 17, 2021
@westonruter
Copy link
Member

I don't know if it would negatively impact your SEO, but we should add rel="nofollow noreferrer noopener" to the link.

@westonruter westonruter added this to the v2.1 milestone Apr 17, 2021
@westonruter
Copy link
Member

Aside: The error message shown in your screenshot should also be much improved once we get to implement #4191.

@westonruter
Copy link
Member

This error message contains a link to https://amp-wp.org/?p=5463 Which I believe no end user would need or want to see.

As noted #6076 (comment), the message will be improved with #4191. But additionally, this message will be shown less frequently entirely due to better handling of redirects. Otherwise, the message is currently there to encourage developers to better handle form submissions in their plugin code.

The SEO concern will be addressed by #6082.

For the rest, please follow #4191.

@westonruter
Copy link
Member

QA Passed

I added a Custom HTML block as follows:

<!-- wp:html -->
<form method=post action="/not-found/">
<input type=text name=name>
<button type=submit>Submit</button>
</form>
<!-- /wp:html -->

On an AMP page, submitting the form results in:

image

The link has nofollow, noreferrer, noopener:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Sanitizers WS:Core Work stream for Plugin core
Projects
None yet
2 participants