Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wizard: Improve layout of Done screen #4972

Closed
westonruter opened this issue Jul 2, 2020 · 1 comment · Fixed by #4980
Closed

Wizard: Improve layout of Done screen #4972

westonruter opened this issue Jul 2, 2020 · 1 comment · Fixed by #4980
Assignees
@amedina
Labels
Changelogged Whether the issue/PR has been added to release notes. UX WS:UX Work stream for UX/Front-end
Milestone
v2.0

Comments

@westonruter
Copy link
Member

Feature description

The layout of the final screen can be improved a bit by reducing the second border around the iframe and moving the heading over the iframe to instead be a caption:

Before After
image image

Also, let's change “Visit in Customizer” to be just “Customize“.

The “Browse AMP Version” could be changed to just “Browse” as well.

It's likely that these buttons will not fit on the same line when translated.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry
@westonruter westonruter added the UX label Jul 2, 2020
@westonruter westonruter added this to the v1.6 milestone Jul 2, 2020
@jwold
Copy link
Collaborator

jwold commented Jul 2, 2020 via email •
edited
Loading

johnwatkins0 added a commit that referenced this issue Jul 3, 2020
@johnwatkins0
(#4972) Update done screen design
01c76ec
@johnwatkins0 johnwatkins0 mentioned this issue Jul 3, 2020
Merged
3 tasks
@kmyram kmyram assigned amedina and unassigned jwold and johnwatkins0 Jul 15, 2020
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 17, 2020
@kmyram kmyram added the WS:UX Work stream for UX/Front-end label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amedina amedina

Labels
Changelogged Whether the issue/PR has been added to release notes. UX WS:UX Work stream for UX/Front-end
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Update wizard UI and improve e2e tests ampproject/amp-wp
5 participants
@westonruter @amedina @kmyram @jwold @johnwatkins0