Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract amp/common & amp/optimizer libraries into separate composer packages #4215

Closed
kmyram opened this issue Feb 3, 2020 · 1 comment
Closed

Extract amp/common & amp/optimizer libraries into separate composer packages #4215

kmyram opened this issue Feb 3, 2020 · 1 comment
Labels
Infrastructure Changes impacting testing infrastructure or build tooling P2 Low priority WS:Perf Work stream for Metrics, Performance and Optimizer

Comments

@kmyram
Copy link

kmyram commented Feb 3, 2020 •
edited
Loading

Feature description

Packaging transformer libraries with Composer for simpler management. Describe and document the individual composer packages and perform the extraction and implementation.

Relates to #4213, #4214, #4216
Related to #958

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The ability to install/remove libraries as composer packages, manually and through script

Implementation brief

  • Simply outline steps to take to package each library in composer
  • Provide overview of affected libraries

QA testing instructions

  • Test the ability to manually and automatically install and remove libraries with Composer

Demo

Changelog entry
@kmyram kmyram added the Infrastructure Changes impacting testing infrastructure or build tooling label Feb 3, 2020
@kmyram kmyram added this to the v2.0 milestone Feb 3, 2020
This was referenced Feb 6, 2020
Closed
Closed
Closed
@kmyram kmyram added the P2 Low priority label Feb 18, 2020
@schlessera schlessera changed the title Extracting libraries into separate composer packages Extract amp/common & amp/optimizer libraries into separate composer packages Feb 18, 2020
@amedina amedina removed this from the v2.0 milestone Mar 31, 2020
@westonruter westonruter mentioned this issue Apr 12, 2020
Closed
@kmyram kmyram added the WS:Perf Work stream for Metrics, Performance and Optimizer label Aug 5, 2020
@schlessera
Copy link
Collaborator

This was fixed via #4215. The two libraries were merged into one separate package at https://github.com/ampproject/amp-toolbox-php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Infrastructure Changes impacting testing infrastructure or build tooling P2 Low priority WS:Perf Work stream for Metrics, Performance and Optimizer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@schlessera @amedina @kmyram