Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated wpcom/shortcodes.php file #1824

Closed
swissspidy opened this issue Jan 17, 2019 · 1 comment · Fixed by #1925
Closed

Remove deprecated wpcom/shortcodes.php file #1824

swissspidy opened this issue Jan 17, 2019 · 1 comment · Fixed by #1925
Labels
Integration: Jetpack
Milestone
v1.2

Comments

@swissspidy
Copy link
Collaborator

wpcom/shortcodes.php (containing wpcom_amp_add_custom_embeds()) was deprecated in 0.6.

We should consider just removing that file at some point, perhaps even in 1.1. I don't know the history of that WordPress.com / Jetpack integration though.
@westonruter
Copy link
Member

I don't know the history of that WordPress.com / Jetpack integration though.

Indeed. It's all supposed to be extracted from the AMP plugin and moved over to Jetpack and WPCOM. See #1021 and #1149.

@swissspidy swissspidy mentioned this issue Mar 5, 2019
Merged
westonruter added a commit that referenced this issue Mar 5, 2019
@westonruter
Remove deprecated/obsolete wpcom/shortcodes.php file
e180515 
Fixes #1824
@westonruter westonruter added this to the v1.2 milestone May 21, 2019
amanintech pushed a commit to amanintech/amp-wp that referenced this issue Oct 20, 2019
@westonruter
Remove deprecated/obsolete wpcom/shortcodes.php file
525b4bd 
Fixes ampproject#1824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Integration: Jetpack
Projects
None yet
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

Remove obsolete Jetpack and WPCOM files ampproject/amp-wp
2 participants
@westonruter @swissspidy