Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show detailed source(s) on error detail view #1459

Closed
westonruter opened this issue Sep 24, 2018 · 3 comments
Closed

Show detailed source(s) on error detail view #1459

westonruter opened this issue Sep 24, 2018 · 3 comments
Labels
Developer Tools P2 Low priority WS:UX Work stream for UX/Front-end

Comments

@westonruter
Copy link
Member

When looking at an error detail view, where there there are the details for a given error shown followed by the URLs that contain that specific error, and with each URL there is the abbreviated list of sources. Given that we have this information, we should also obtain the full source stack information as is shown with each validation error on the Invalid URL screen:

untitled 12

The list of sources should be a unique list based on the sources for the URLs shown on the current screen.

@westonruter westonruter added this to the v1.1 milestone Sep 24, 2018
@westonruter westonruter changed the title Show source(s) on error detail view Show detailed source(s) on error detail view Sep 24, 2018
@westonruter westonruter removed this from the v1.1 milestone Mar 6, 2019
@westonruter
Copy link
Member Author

To be tackled as part of #2316.

@amedina amedina added P2 Low priority UX Phase 2 labels May 14, 2020
@kmyram kmyram added the WS:UX Work stream for UX/Front-end label May 15, 2020
@westonruter
Copy link
Member Author

This issue is about adding the Source Stack to the single Validation Error screen, whereas currently it is only on the Validated URL screen. The reason why it is only on the latter is that source stacks need the URL context to determine where they came from. Source stack information is only stored with the validated URLs.

If the source stacks from a validation error on multiple URLs are not the same, instead of trying to merge them into one stack, we can instead show a message to say that the user needs to go to the validated URLs to see the source stack in context.

@jwold
Copy link
Collaborator

jwold commented Jan 19, 2021

Weston > The source info for an error is only captured in the context of a url where the error occurs. So this ticket was about trying to add the sources for all instances to this screen. However, we now are directing users always to go to the validated url screen to do any actions on the validation errors. You go to the validated urls screen to see source, mark as reviewed, remove or keep, so this screen may not be worth it. Let's close it.

@jwold jwold closed this as completed Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Tools P2 Low priority WS:UX Work stream for UX/Front-end
Projects
None yet
Development

No branches or pull requests

4 participants