-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On single error URL page, integrate sources in expanded 'Error' section with 'Sources' column #1450
Comments
In the same way that expanding the details creates a new table row with all the details information, what if expanding the sources did the same for the source information? Maybe the inserted table row could have a background color set on it which is then also set on the table cell that was expanded. This would help associate the inserted row with the cell you just expanded to have more details. I wonder if we need a dropdown to expand each individual source type. In the screenshot above, do we need the toggle with Other? If we only had hone toggle at the top and this caused all of them to be expanded, then it could also be responsible for inserting the new row for the source information. If you expand the source information, then the error details should be collapsed, and vice-versa. |
Hi @westonruter,
Thanks, that's interesting. Is this roughly what you had in mind? |
@kienstra not necessarily floated to the right, but yes. When expanded, the background color of the sources table cell and the sources row could be set to light gray to show they are connected perhaps. the background color could be removed when the sources are collapsed. Something similar could be done for the details cell. |
Thanks, @westonruter. Do you think this is something that could wait until the next Beta version? This might need a similar approach to the expandable error column, where this added a new |
Yes, this can wait for the next release. |
It will be particularly helpful to be able to use the double-arrow in the table header to expand all the sources to be able to do a quick browser find. Likewise it would be helpful to have the same expansion ability for the error column so you can see all details at once. Maybe what I suggested where expanding details should collapse sources, and vice-versa, isn't great because maybe you'd want to have all the data spit out onto the page at once. |
Additionally: On the error detail view, when we list the single validation error and the associated URLs, we should show the detailed source information as well. I've filed this as #1459. |
Part of #2316. |
Weston > We have a summary of the source validation error and also have the full details. Those are not connected and should be combined. This is a low priority item, and is part of tightening up and improving design of validated URL screen. |
As @westonruter mentioned, the sources appear in 2 places on the single error URL page:
This can be confusing.
How can we make this clearer? Maybe expand the
sources
in the 'Error' column on expanding the summary 'Sources' column?The text was updated successfully, but these errors were encountered: