Refactoring and improving validation error handling (#2285)

Refactoring and improving validation error handling
ampproject · May 15, 2019 · b1993bf · b1993bf
2 parents c195425 + 6978673
commit b1993bf
Show file tree

Hide file tree

Showing 50 changed files with 2,279 additions and 2,207 deletions.
diff --git a/assets/src/amp-validation/amp-validated-url-post-edit-screen.js b/assets/src/amp-validation/amp-validated-url-post-edit-screen.js
diff --git a/assets/src/amp-validation/amp-validated-urls-index.js b/assets/src/amp-validation/amp-validated-urls-index.js
@@ -1,34 +1,14 @@
-/* exported ampValidatedUrlsIndex */
-
-const ampValidatedUrlsIndex = ( function() { // eslint-disable-line no-unused-vars
-	const component = {
-		classes: {},
-	};
-
-	/**
-	 * The class for the new status
-	 *
-	 * @type {string}
-	 */
-	component.classes.new = 'new';
-
-	/**
-	 * Boot.
-	 */
-	component.boot = function boot() {
-		component.highlightRowsWithNewStatus();
-	};
-
-	/**
-	 * Highlight rows with new status.
-	 */
-	component.highlightRowsWithNewStatus = function highlightRowsWithNewStatus() {
-		document.querySelectorAll( 'tr[id^="post-"]' ).forEach( function( row ) {
-			if ( row.querySelector( 'span.status-text.' + component.classes.new ) ) {
-				row.classList.add( 'new' );
-			}
-		} );
-	};
-
-	return component;
-}() );
+/**
+ * WordPress dependencies
+ */
+import domReady from '@wordpress/dom-ready';
+
+const CLASS_NAME = 'new';
+
+domReady( () => {
+	document.querySelectorAll( 'tr[id^="post-"]' ).forEach( function( row ) {
+		if ( row.querySelector( 'span.status-text.' + CLASS_NAME ) ) {
+			row.classList.add( CLASS_NAME );
+		}
+	} );
+} );
diff --git a/assets/src/amp-validation/amp-validation-detail-toggle.js b/assets/src/amp-validation/amp-validation-detail-toggle.js
@@ -1,12 +1,8 @@
-/**
- * External dependencies
- */
-import { detailToggleBtnAriaLabel, sourcesToggleBtnAriaLabel } from 'amp-validation-i18n';
-
 /**
  * WordPress dependencies
  */
 import domReady from '@wordpress/dom-ready';
+import { __ } from '@wordpress/i18n';
 
 const OPEN_CLASS = 'is-open';
 
@@ -80,7 +76,7 @@ function addTermListTableRowClasses() {
 }
 
 domReady( () => {
-	addToggleButtons( 'th.column-details.manage-column', detailToggleBtnAriaLabel )
+	addToggleButtons( 'th.column-details.manage-column', __( 'Toggle all details', 'amp' ) )
 		.forEach( ( btn ) => {
 			addToggleAllListener( {
 				btn,
@@ -89,7 +85,7 @@ domReady( () => {
 			} );
 		} );
 
-	addToggleButtons( 'th.manage-column.column-sources_with_invalid_output', sourcesToggleBtnAriaLabel )
+	addToggleButtons( 'th.manage-column.column-sources_with_invalid_output', __( 'Toggle all sources', 'amp' ) )
 		.forEach( ( btn ) => {
 			addToggleAllListener( {
 				btn,