Skip to content

Commit

Permalink
Update contributing instructions for current amphtml-update process
Browse files Browse the repository at this point in the history
  • Loading branch information
westonruter committed Feb 20, 2019
1 parent 65cb7cd commit 636a843
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,18 @@ This will create an `amp.zip` in the plugin directory which you can install. The
## Updating Allowed Tags And Attributes

The file `class-amp-allowed-tags-generated.php` has the AMP specification's allowed tags and attributes. It's used in sanitization.
To update that file:

To update that file, perform the following steps (which need to be improved):

1. `cd` to the root of this plugin
2. run `bash bin/amphtml-update.sh`
That script is intended for a Linux environment like [VVV](https://github.com/Varying-Vagrant-Vagrants/VVV).
2. Find the most recent stable release of AMP at https://github.com/ampproject/amphtml/releases (e.g. 1902081532110)
3. Update `composer.json` replacing the old tag references for `ampproject/amphtml` to the latest version.
4. Run `rm composer.lock && composer install`.
5. Run `bash bin/amphtml-update.sh` (or `lando ssh -c 'bash bin/amphtml-update.sh'` if using Lando)
6. Update tests based on changes to the spec.
7. Commit changes.

This script is intended for a Linux environment like [VVV](https://github.com/Varying-Vagrant-Vagrants/VVV) or [Lando wordpressdev](https://github.com/felixarntz/wordpressdev).

## Testing Media And Embed Support

Expand Down

0 comments on commit 636a843

Please sign in to comment.