-
Notifications
You must be signed in to change notification settings - Fork 383
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
8 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c059fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this disabled?
2c059fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GaryJones Since this change was part of a PR for analytics (#714), I'm guessing the reason to hide was to prevent analytics from being supplied on WordPress.com. So it seems that this needs to be removed in favor of WordPress.com specifically removing the menu for analytics. /cc @mjangda
2c059fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other words, this code would need to be disabled or undone:
https://github.com/Automattic/amp-wp/blob/32703d696fdcba9b1511fbfb7c3a2366d6ebd999/includes/options/class-amp-analytics-options-submenu.php#L23-L40