Harden logic for normalizing image metadata before adding story images

ampproject · Aug 19, 2019 · 205d436 · 205d436
1 parent cc10a5d
commit 205d436
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/includes/class-amp-story-media.php b/includes/class-amp-story-media.php
@@ -141,12 +141,12 @@ public static function filter_schemaorg_metadata_images( $data ) {
 			return $data;
 		}
 
-		if ( ! isset( $data['image'] ) ) {
-			$data['image'] = [];
-		} elseif ( is_string( $data['image'] ) ) {
+		if ( is_string( $data['image'] ) ) {
 			$data['image'] = [ $data['image'] ];
-		} elseif ( isset( $data['image']['@type'] ) ) {
+		} elseif ( is_array( $data['image'] ) && isset( $data['image']['@type'] ) ) {
 			$data['image'] = [ $data['image'] ];
+		} elseif ( ! is_array( $data['image'] ) ) {
+			$data['image'] = [];
 		}
 
 		$data['image'] = array_merge(