Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode SVG sizer with base64 #981

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Encode SVG sizer with base64 #981

merged 2 commits into from
Dec 15, 2020

Conversation

schlessera
Copy link
Collaborator

Fixes #844

sebastianbenz
sebastianbenz approved these changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks a lot!

@sebastianbenz sebastianbenz merged commit 1814e29 into ampproject:main Dec 15, 2020
@schlessera schlessera deleted the fix/844-default-to-base64-encoded-svgs branch December 15, 2020 14:12
@schlessera schlessera mentioned this pull request Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianbenz sebastianbenz sebastianbenz approved these changes

Assignees
No one assigned
Labels
enhancement toolbox-optimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use base64 encoding for sizer SVGs
2 participants
@schlessera @sebastianbenz