Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing closing tags to <amp-img> elements #918

Merged

Conversation

schlessera
Copy link
Collaborator

The input.html file for the PreloadHeroImage/srcset_cannot_be_preloaded spec test is missing the closing tags for its <amp-img> elements. This causes the DOM to get corrupted when imported and the <amp-img> elements to be inadvertently nested.

Fixes #917

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2020

CLA assistant check
All committers have signed the CLA.

@patrickkettner
Copy link
Collaborator

thanks!

@patrickkettner patrickkettner merged commit 77c3515 into ampproject:main Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec file missing closing <amp-img> tags
3 participants