Preload checks for blocking extensions #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preload check for runtime allows hosted version and javascript module version
| .map((s) => `[${s}]`) | ||
| .join(""); | ||
| const isPreloaded = $(`link${attr}`).length > 0; | ||
| const mjsAttr = ["href$='/v0.mjs'", "rel='modulepreload'"] |
There was a problem hiding this comment.
We're currently not using modulepreload so please omit checking for this attribute
There was a problem hiding this comment.
For mjs we now simply check if the rel attribute ends with preload, so normal preload (as it is used now) or modulepreload will be fine.
sebastianbenz
approved these changes
Aug 19, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preload check for runtime now also allows hosted version and javascript module version.
Do we need to change the warning message now?