Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add experimental amp-img -> img transformation #859

Merged
merged 9 commits into from
Jul 15, 2020
Merged

add experimental amp-img -> img transformation #859

merged 9 commits into from
Jul 15, 2020

Commits on Jul 9, 2020

  1. add experimental amp-img -> img transformation

    @sebastianbenz
    sebastianbenz committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2c7a3be View commit details
    Browse the repository at this point in the history

  2. add attributes test

    @sebastianbenz
    sebastianbenz committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d695e9f View commit details
    Browse the repository at this point in the history

  3. add attributes test

    @sebastianbenz
    sebastianbenz committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    16c4688 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. generate img for amp-iframe placeholder

    @sebastianbenz
    sebastianbenz committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    425b9a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. Add support for data-hero 

    This commit introduces the data-hero attribute as a means to explicitly
markup hero amp-img or amp-iframe elemenents.

Other changes:

* don't bail out if there are any kind of image preloads, instead check
the img src to avoid duplicates
* use loading=eager instead of loading=lazy
    @sebastianbenz
    sebastianbenz committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    d41daaa View commit details
    Browse the repository at this point in the history

  2. addressed comment

    @sebastianbenz
    sebastianbenz committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    33daf9b View commit details
    Browse the repository at this point in the history

  3. insert sizer first

    @sebastianbenz
    sebastianbenz committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    8574987 View commit details
    Browse the repository at this point in the history

  4. print warning if there are too many hero elements on a page

    @sebastianbenz
    sebastianbenz committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    a3601de View commit details
    Browse the repository at this point in the history

  5. remove loading=eager

    @sebastianbenz
    sebastianbenz committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    ea594ba View commit details
    Browse the repository at this point in the history