Rename download-runtime => runtime-fetch #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbenz
force-pushed
the
rename-runtime-download
branch
from
cb18b63
to
82a58f5
Compare
mdmower
reviewed
Apr 3, 2020
| @@ -19,7 +19,7 @@ const cacheListProvider = require('@ampproject/toolbox-cache-list'); | |||
| const crossFetch = require('cross-fetch'); | |||
| const fse = require('fs-extra'); | |||
| const https = require('https'); | |||
| const log = require('@ampproject/toolbox-core').log.tag('AMP Download Runtime'); | |||
| const log = require('@ampproject/toolbox-core').log.tag('Runtime Fetch'); | |||
There was a problem hiding this comment.
nit: Tag doesn't match tool name; this is the only place "Runtime Fetch" is user facing.
There was a problem hiding this comment.
renamed to Runtime Download
mdmower
approved these changes
Apr 3, 2020
NPM doesn't allow modules containing `download`.
sebastianbenz
force-pushed
the
rename-runtime-download
branch
from
82a58f5
to
2d99e9f
Compare
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM doesn't allow modules containing
download.