Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimizer: Make dynamic component URL rewrites optional #518

Merged
merged 1 commit into from
Oct 9, 2019
Merged

optimizer: Make dynamic component URL rewrites optional #518

merged 1 commit into from
Oct 9, 2019

Commits on Oct 9, 2019

  1. optimizer: Make dynamic component URL rewrites optional 

    Not everyone who self-hosts the AMP runtime has the infrastructure to
support dynamic components like amp-geo, ref:
https://github.com/ampproject/amphtml/blob/master/spec/amp-cache-guidelines.md#guidelines-adding-a-new-cache-to-the-amp-ecosystem

Introduce option rewriteDynamicComponents that prevents modification of
dynamic component URLs that would otherwise have ampUrlPrefix
substituted.

Two relevant tests added:
 rewrites_host_but_not_dynamic_components_with_rtv
 rewrites_host_but_not_dynamic_components_without_rtv
    @mattwomple
    mattwomple committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    3354b6a View commit details
    Browse the repository at this point in the history