Support script based templates #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's documented here: https://amp.dev/documentation/components/amp-mustache/. |
|
oh, pft, I somehow changed it to amp-script powered templates when I was looking for docs. apologies. |
sebastianbenz
force-pushed
the
templates
branch
from
8b3be15
to
1c24fbd
Compare
Make sure to always also support the script based template syntax:
```
<script type="text/plain" template="amp-mustache">
Hello {{world}}!
</script>
```
Using the template helper should also make SSR more performant as it
avoids a full parent traversal for each node.
sebastianbenz
force-pushed
the
templates
branch
from
098ae90
to
d570011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to always also support the script based template syntax:
Using the template helper should also make SSR more performant as it
avoids a full parent traversal for each node.