Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse document correctly when AMP emoji is used #79

Merged
merged 25 commits into from
Mar 16, 2021
Merged

Parse document correctly when AMP emoji is used #79

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
2f6221c
Add breaking test cases
schlessera Feb 23, 2021
1bd3177
Add missing emoji in test case
schlessera Mar 4, 2021
6efcf72
Make emoji replacement more robust
schlessera Mar 4, 2021
e6227be
Try to restore amp-bind attributes faithfully so as to preserve bind …
schlessera Feb 19, 2021
fdaf878
Adapt tests for restored bind attributes
schlessera Mar 4, 2021
27e90e0
Change order of conversions to ensure the AMP emoji does not break th…
schlessera Mar 4, 2021
0a766d4
Add option mechanism to Dom\Document
schlessera Mar 5, 2021
ab4e380
Add logic to configure amp-bind conversions
schlessera Mar 5, 2021
083cd3f
Test different amp-bind conversion options
schlessera Mar 5, 2021
0735110
Add test case to ensure amp-bind syntax within content remains untouched
schlessera Mar 6, 2021
8b92e2a
Use tag & attribute traversal to avoid replacing amp-bind syntax in c…
schlessera Mar 8, 2021
5b21890
Correct type hint for option default values array
schlessera Mar 9, 2021
bd58f49
Optimize AMP emoji conversion algorithm
schlessera Mar 15, 2021
0cd3a32
Extract option constants into their own interface
schlessera Mar 15, 2021
f497bec
Extract encoding constants into a separate interface
schlessera Mar 15, 2021
60130e5
Always add a value on bound attributes
schlessera Mar 15, 2021
7719483
Import Encoding & Option interfaces
schlessera Mar 15, 2021
bde0ee8
Fix bug in encoding sanitization
schlessera Mar 15, 2021
ca995d0
Improve encoding auto-detection on bad charset markup
schlessera Mar 15, 2021
c392699
Fix bug with ignored originalEncoding
schlessera Mar 15, 2021
07f12ac
Test whether upper case encodings work
schlessera Mar 15, 2021
0346a71
Test options parsing
schlessera Mar 15, 2021
187bdb9
Add coverage hints
schlessera Mar 15, 2021
61b04d2
Add test case for latin-1 mapping
schlessera Mar 15, 2021
f8e0bb0
Ignore code coverage for untestable edge case
schlessera Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading