Merge pull request #135 from ampproject/fix/127-dont-preload-hero-images

Only construct preload if it is needed
ampproject · Apr 8, 2021 · c9d317a · c9d317a
2 parents 0a96b1d + 24871ec
commit c9d317a
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/Optimizer/Transformer/PreloadHeroImage.php b/src/Optimizer/Transformer/PreloadHeroImage.php
@@ -496,6 +496,12 @@ private function generatePreload(
             $img->removeAttribute(Attribute::LOADING);
         }
 
+        if (empty($heroImage->getMedia())) {
+            // We can only safely preload a hero image if there's a media attribute
+            // as we can't detect whether it's hidden on certain viewport sizes otherwise.
+            return;
+        }
+
         if ($this->hasExistingImagePreload($document, $heroImage->getSrc())) {
             return;
         }
@@ -516,12 +522,6 @@ private function generatePreload(
             }
         }
 
-        if (empty($heroImage->getMedia())) {
-            // We can only safely preload a hero image if there's a media attribute
-            // as we can't detect whether it's hidden on certain viewport sizes otherwise.
-            return;
-        }
-
         $preload->setAttribute(Attribute::MEDIA, $heroImage->getMedia());
 
         if ($this->preloadReferenceNode) {