Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of new and removed OWNERS files in cache #1279

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Improve handling of new and removed OWNERS files in cache #1279

merged 3 commits into from
Apr 28, 2021

Conversation

rcebulko
Copy link
Contributor

Currently the bot uses the GitHub Search API + file SHAs to identify new/changed OWNERS files. The search API seems to be returning incomplete results, meaning some files never get seen with updated SHAs and can get stale. This PR:

  • causes the virtual repo to manually re-fetch any OWNERS files it thinks exist, but weren't present in search results
  • removes OWNERS files from the in-memory cache if attempting fetching them returns an error

@rcebulko rcebulko merged commit 46d0fa0 into ampproject:main Apr 28, 2021
@rcebulko rcebulko deleted the owners-cache branch April 28, 2021 19:42
@rcebulko rcebulko mentioned this pull request May 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrozenberg danielrozenberg danielrozenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcebulko @danielrozenberg