Md create html document (rrweb-io#1321)

* only call createHTMLDocument where it is needed * Perf: create the mutation document once as a 'singleton' as it can be reused --------- Co-authored-by: Michael Dellanoce <[email protected]>
amplitude · Jul 31, 2024 · b29bfca · b29bfca
1 parent 3bfcc54
commit b29bfca
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/packages/rrweb/src/record/mutation.ts b/packages/rrweb/src/record/mutation.ts
@@ -190,6 +190,7 @@ export default class MutationBuffer {
   private shadowDomManager: observerParam['shadowDomManager'];
   private canvasManager: observerParam['canvasManager'];
   private processedNodeManager: observerParam['processedNodeManager'];
+  private unattachedDoc: HTMLDocument;
 
   public init(options: MutationBufferParam) {
     (
@@ -592,15 +593,17 @@ export default class MutationBuffer {
             value,
           );
           if (attributeName === 'style') {
-            let unattachedDoc;
-            try {
-              // avoid upsetting original document from a Content Security point of view
-              unattachedDoc = document.implementation.createHTMLDocument();
-            } catch (e) {
-              // fallback to more direct method
-              unattachedDoc = this.doc;
+            if (!this.unattachedDoc) {
+              try {
+                // avoid upsetting original document from a Content Security point of view
+                this.unattachedDoc =
+                  document.implementation.createHTMLDocument();
+              } catch (e) {
+                // fallback to more direct method
+                this.unattachedDoc = this.doc;
+              }
             }
-            const old = unattachedDoc.createElement('span');
+            const old = this.unattachedDoc.createElement('span');
             if (m.oldValue) {
               old.setAttribute('style', m.oldValue);
             }