fix: when retries is set to zero, throw the error

amplitude · Dec 20, 2024 · 3bcb5a1 · 3bcb5a1
1 parent fcc3723
commit 3bcb5a1
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/packages/node/src/remote/client.ts b/packages/node/src/remote/client.ts
@@ -68,7 +68,7 @@ export class RemoteEvaluationClient {
       console.error('[Experiment] Fetch failed: ', e);
       if (this.shouldRetryFetch(e)) {
         try {
-          return await this.retryFetch(user, options);
+          return await this.retryFetch(user, options, e);
         } catch (e) {
           console.error(e);
         }
@@ -117,13 +117,10 @@ export class RemoteEvaluationClient {
 
   private async retryFetch(
     user: ExperimentUser,
-    options?: FetchOptions,
+    options: FetchOptions,
+    err: Error,
   ): Promise<Record<string, Variant>> {
-    if (this.config.fetchRetries == 0) {
-      return {};
-    }
     this.debug('[Experiment] Retrying fetch');
-    let err: Error = null;
     let delayMillis = this.config.fetchRetryBackoffMinMillis;
     for (let i = 0; i < this.config.fetchRetries; i++) {
       await sleep(delayMillis);