Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose stop() as part of ExperimentClient protocol #58

Closed
peppesapienza opened this issue Sep 10, 2024 · 1 comment
Closed

Expose stop() as part of ExperimentClient protocol #58

peppesapienza opened this issue Sep 10, 2024 · 1 comment

Comments

@peppesapienza
Copy link
Contributor

Ehi,

Considering stop has been defined as public in DefaultExperimentClient, it should probably be exposed as part of the ExperimentClient protocol.
peppesapienza added a commit to peppesapienza/experiment-ios-client that referenced this issue Sep 10, 2024
@peppesapienza
fix: Make stop method public
1136cee 
amplitude#58
@peppesapienza peppesapienza mentioned this issue Sep 10, 2024
Merged
@tyiuhc
Copy link
Collaborator

tyiuhc commented Sep 10, 2024

@peppesapienza Many thanks for raising this issue. stop() is now exposed in v1.13.6

@tyiuhc tyiuhc closed this as completed Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peppesapienza @tyiuhc