-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for Flutter Web on Flutter 4.0 #456
Conversation
chungdaniel
commented
Jan 10, 2025
- Added new configuration options for Flutter Web
- Added snippet to use for setting up Flutter projects with Amplitude Browser SDK in web/index.html
- Add changes to migration guide
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel for updating the docs
|
||
| Name | Description | Default Value | | ||
| ---------- | ----------------------------------------------------------------------------------------------------------- | ------------- | | ||
| `deviceId` | `String`. The device ID to use for this device. If you don't provide a `deviceId`, Amplitude generates one. | `null` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised that android sdk supports device id https://github.com/amplitude/Amplitude-Kotlin/blob/74764561d2c87c5eb6f59198822f93ca249178ad/core/src/main/java/com/amplitude/core/Configuration.kt#L34 but the ios sdk doesn't https://github.com/amplitude/Amplitude-Swift/blob/98a5f020359d6e4c02f774a57d31b2fc7d062f46/Sources/Amplitude/Configuration.swift#L185
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also found it strange, though the code reflects this. Should we have any sort of follow-up/investigation created for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extension of #456; needed to request review from SDK team and address comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responded to comments, opened new PR to address comments https://github.com/amplitude/amplitude-docs/pull/462/files
|
||
| Name | Description | Default Value | | ||
| ---------- | ----------------------------------------------------------------------------------------------------------- | ------------- | | ||
| `deviceId` | `String`. The device ID to use for this device. If you don't provide a `deviceId`, Amplitude generates one. | `null` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also found it strange, though the code reflects this. Should we have any sort of follow-up/investigation created for this?