Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for Flutter Web on Flutter 4.0 #456

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

chungdaniel
Copy link
Contributor

  • Added new configuration options for Flutter Web
  • Added snippet to use for setting up Flutter projects with Amplitude Browser SDK in web/index.html

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
amplitude-docs ✅ Ready (Inspect) Visit Preview Jan 10, 2025 10:52pm

@chungdaniel chungdaniel changed the title Amp 121105 flutter web docs Add docs for Flutter Web on Flutter 4.0 Jan 10, 2025
@chungdaniel chungdaniel merged commit d4787d7 into main Jan 10, 2025
4 checks passed
@chungdaniel chungdaniel requested review from izaaz and Mercy811 January 14, 2025 02:31
Copy link
Contributor

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel for updating the docs


| Name | Description | Default Value |
| ---------- | ----------------------------------------------------------------------------------------------------------- | ------------- |
| `deviceId` | `String`. The device ID to use for this device. If you don't provide a `deviceId`, Amplitude generates one. | `null` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also found it strange, though the code reflects this. Should we have any sort of follow-up/investigation created for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crleona @igor-amp any ideas?

@chungdaniel chungdaniel deleted the AMP-121105-flutter-web-docs branch January 14, 2025 18:59
chungdaniel added a commit that referenced this pull request Jan 14, 2025
Extension of #456; needed to request review from SDK team and address comments.
Copy link
Contributor Author

@chungdaniel chungdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded to comments, opened new PR to address comments https://github.com/amplitude/amplitude-docs/pull/462/files


| Name | Description | Default Value |
| ---------- | ----------------------------------------------------------------------------------------------------------- | ------------- |
| `deviceId` | `String`. The device ID to use for this device. If you don't provide a `deviceId`, Amplitude generates one. | `null` |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also found it strange, though the code reflects this. Should we have any sort of follow-up/investigation created for this?

@chungdaniel chungdaniel requested a review from Mercy811 January 14, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants