Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP-120844 [ga4Import] Create a developer doc for GA4 Import #448

Merged
merged 13 commits into from
Jan 25, 2025

Conversation

bh202205
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
amplitude-docs ✅ Ready (Inspect) Visit Preview Jan 25, 2025 0:43am

@bh202205 bh202205 changed the title AMP-120844 [ga4-import] draft created AMP-120844 [ga4Import] Create a developer doc for GA4 Import Jan 24, 2025
@bh202205 bh202205 marked this pull request as ready for review January 24, 2025 06:44
@bh202205 bh202205 requested a review from fzqgriffin January 24, 2025 06:44
Copy link
Contributor

@fzqgriffin fzqgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. left 2 comments.

content/collections/source-catalog/en/ga4.md Outdated Show resolved Hide resolved
content/collections/source-catalog/en/ga4.md Show resolved Hide resolved
content/collections/source-catalog/en/ga4.md Outdated Show resolved Hide resolved
content/collections/source-catalog/en/ga4.md Outdated Show resolved Hide resolved
content/collections/source-catalog/en/ga4.md Outdated Show resolved Hide resolved
@bh202205
Copy link
Contributor Author

@markzegarelli addressed your comments. Would you mind taking another look?

@bh202205
Copy link
Contributor Author

@markzegarelli thank you for reviewing the doc for me. I will merge it once the checks finished.

@bh202205 bh202205 merged commit 4a5dbfe into main Jan 25, 2025
4 checks passed
@bh202205 bh202205 deleted the AMP-120844-ga4-import-developer-doc branch January 25, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants