-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMP-120844 [ga4Import] Create a developer doc for GA4 Import #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bh202205
changed the title
AMP-120844 [ga4-import] draft created
AMP-120844 [ga4Import] Create a developer doc for GA4 Import
Jan 24, 2025
fzqgriffin
reviewed
Jan 24, 2025
fzqgriffin
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. left 2 comments.
markzegarelli
requested changes
Jan 24, 2025
@markzegarelli addressed your comments. Would you mind taking another look? |
…itude/amplitude-docs into AMP-120844-ga4-import-developer-doc
…com/amplitude/amplitude-docs into AMP-120844-ga4-import-developer-doc
markzegarelli
approved these changes
Jan 25, 2025
@markzegarelli thank you for reviewing the doc for me. I will merge it once the checks finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.