-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Swift UserId and DeviceId setter #299
Changes from 2 commits
a514575
4dc3275
0922780
748a277
0942f77
30c6f02
2498d2b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,6 +87,8 @@ @interface Amplitude() | |
@property (nonatomic, assign) long long sessionId; | ||
@property (nonatomic, assign) BOOL backoffUpload; | ||
@property (nonatomic, assign) int backoffUploadBatchSize; | ||
@property (nonatomic, copy, readwrite, nullable) NSString *userId; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will allow user to call setter without changing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed so readwrite occurs in header instead of implementation There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will revert so that we can solve the method syntax bug |
||
@property (nonatomic, copy, readwrite) NSString *deviceId; | ||
#if TARGET_OS_IOS || TARGET_OS_MACCATALYST | ||
@property (nonatomic, strong) AMPEventExplorer *eventExplorer; | ||
#endif | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no space in between for
(NSString*) userId