Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support to \n separated request body for ga forwarding #903

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

kevinpagtakhan
Copy link
Collaborator

Summary

When this feature was originally built, GA sent bulk events in a single request using the request payload. The request payload is a list of valid query parameter formatted string separated by the \\r\\ character. A customer reported that their GA-forwarded events are not being formatted correctly. After some investigating, we are seeing the list of valid query parameter formatted stings are separated by \n character. The changes here include adding support to \n separated strings and ignoring events that are formatted outside the supported formats.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@kevinpagtakhan kevinpagtakhan requested a review from a team October 24, 2024 21:48
@kevinpagtakhan kevinpagtakhan marked this pull request as ready for review October 24, 2024 21:58
Copy link
Contributor

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin for adding this. Overall looks good to me. See the comment about the change to user id.

@kevinpagtakhan kevinpagtakhan merged commit 2b06701 into v1.x Oct 25, 2024
3 checks passed
@kevinpagtakhan kevinpagtakhan deleted the AMP-117262 branch October 25, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants