Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Page counter fix #670

Merged
merged 4 commits into from
Feb 27, 2024
Merged

fix: Page counter fix #670

merged 4 commits into from
Feb 27, 2024

Conversation

yuhao900914
Copy link
Contributor

@yuhao900914 yuhao900914 commented Feb 27, 2024 •
edited
Loading

Summary

The original way didn't cover the single-page application at here.

The current way is:

  • save the BrowserConfig while page view plugin set up.
  • update the pageCounter while track page view event

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

izaaz
izaaz approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@izaaz izaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Thanks for fixing this @yuhao900914.

@yuhao900914 yuhao900914 merged commit 1bd9105 into main Feb 27, 2024
4 checks passed
@yuhao900914 yuhao900914 deleted the pageCounterFix branch February 27, 2024 19:02
@Mercy811 Mercy811 mentioned this pull request Mar 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

@Mercy811 Mercy811 Mercy811 approved these changes

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@izaaz izaaz izaaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuhao900914 @izaaz @justin-fiedler @Mercy811 @qingzhuozhen