Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): change java version to 17 to support RN 0.73+ #617

Closed

Conversation

kesha-antonov
Copy link

Summary

Hi

Based on react-native-community/discussions-and-proposals#671

to support RN 0.73+ we have to use java 17

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: Yes

@RyanLRKuhn
Copy link

Can we get this merged in? This library still does not work for Gradle 8.3+ and RN 73.

@grifotv
Copy link

grifotv commented Sep 12, 2024

Would this be related to this build error mentioned here?

A problem occurred evaluating project ':app'.
> Failed to apply plugin 'com.facebook.react'.
   > The value for property 'languageVersion' is final and cannot be changed any further.

@RyanLRKuhn
Copy link

Would this be related to this build error mentioned here?

A problem occurred evaluating project ':app'.
> Failed to apply plugin 'com.facebook.react'.
   > The value for property 'languageVersion' is final and cannot be changed any further.

I hope so 😅 That's the error I get trying to use the analytics SDK. I've tried patching the library and looked into all possible causes and can't find any explicit issues with this SDK. Despite all that I still cannot use this library. I'm hoping this PR helps resolve the issue but can't be certain since I can't pinpoint the exact problem.

@Mercy811
Copy link
Contributor

Hi @kesha-antonov, Amplitude's React Native package has compile options set to Java 8. It can run within an app using Java 17 because of Java is backward compatible. Updating to Java 17 seems to be required only to app developers but not library developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants