Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log error trace in catch blocks #605

Merged
merged 2 commits into from
Oct 26, 2023
Merged

fix: log error trace in catch blocks #605

merged 2 commits into from
Oct 26, 2023

Conversation

kevinpagtakhan
Copy link
Collaborator

Summary

Logs caught errors before stringifying

  • Allows complete error trace to be logged using the logger provider

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@kevinpagtakhan kevinpagtakhan self-assigned this Oct 25, 2023
@kevinpagtakhan kevinpagtakhan merged commit 95f7249 into v1.x Oct 26, 2023
3 checks passed
@kevinpagtakhan kevinpagtakhan deleted the log-error-trace branch October 26, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mercy811 Mercy811 Mercy811 approved these changes

@justin-fiedler justin-fiedler justin-fiedler approved these changes

@bgiori bgiori Awaiting requested review from bgiori

Assignees

@kevinpagtakhan kevinpagtakhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinpagtakhan @justin-fiedler @Mercy811